fix(apple): read Gemfile & fallback to globally installed pod#2629
Closed
szymonrybczak wants to merge 2 commits intomainfrom
Closed
fix(apple): read Gemfile & fallback to globally installed pod#2629szymonrybczak wants to merge 2 commits intomainfrom
Gemfile & fallback to globally installed pod#2629szymonrybczak wants to merge 2 commits intomainfrom
Conversation
Collaborator
Author
|
cc @tido64 I hope that with this one we'll finally make everything work in your setup 🤞 |
szymonrybczak
changed the title
Gemfile & fallback to globally installed podGemfile & fallback to globally installed pod
Contributor
|
The changes worked well for me. 🚀 I tested using the React Native RNTester app. It's certainly an improvement that helps fix the issues we are seeing in release 19.0.0. Could we merge these changes? It would help me out by having these changes in future releases. 🙇 |
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some projects have
Gemfilein the root directory but for other purposes, so checking if it's presented is not enough.This Pull Request adds reading and simple regex to check if
gem cocoapodsis included which should make the workflow more solid.Also this Pull Requests adds a fallback if for any reason CLI decided to install with
bundle exec pod installwe fail silently and fallback to globally installedpod.Test Plan
yarn add react-native-svgGemfileand runrun-iosChecklist
react-nativecheckout (instructions).